feat: Automatically install wasm32-unknown-unknown #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables automatic installation of the wasm32-unknown-unknown target for the `build` and `check` commands. The installation will be performed if: 1. No `target` param is specified 2. The `wasm32-unknown-unknown` target is not already installed 3. `rustup` is available as the toolchain installer
peterhuene
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
This looks good 👍.
Regarding caching the results of the check, I think we can live without that for now but perhaps file an issue to track potentially implementing it if it proves that always having the additional rustc invocation is undesirable (can be avoided by manually specifying the target for now, at least).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #9
This commit enables automatic installation of the wasm32-unknown-unknown target for the
buildandcheckcommands.The installation will be performed if:
targetparam is specifiedwasm32-unknown-unknowntarget is not already installedrustupis available as the toolchain installerThis implementation is based on cargo-wasi's
install_wasi_target, with the difference that I'm not introducing a cache for the target check.I opted to leave the cache implementation up for discussion mainly because: (i) the cache can potentially introduce false positives if for example, the user removes the target manually after running
buildorcheckfor the first time, so if we go ahead with the implementation we might need to think about an "eviction" mechanism analogous tocargo wasi self cleanor think of a different caching approach (ii) cargo-wasi has several use-cases for the cache: one being the target installation and the other one being update-checks, perhaps if update checks is something that we want to implement we could add the caching at that time? Right now we'd mostly be saving therustc --print sysrootinvocation. Thoughts?